Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.0-0.1.0: [feature] - Optional dappId when apiUrl #202

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Description

The Blocknative server now allows authentication with an API key as a query parameter in the initial http upgrade request rather than needing to pass the API key as the dappId parameter within the initial message. This can be useful in the case of using a WebSocket proxy to hide the API key.

This PR changes the types so that the either a dappId or a apiUrl needs to be passed in to initialization and assumes that the API key is included in the apiUrl as a query parameter.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does any documentation need to be added around this change?

@lnbc1QWFyb24
Copy link
Collaborator Author

@Adamj1232 Yes there will be documentation changes needed, but we are waiting on the implementation on the server to define the name of the query parameter.

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit e7292f9 into develop Aug 8, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the feature/apikey-query-param branch August 8, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants