Restore lost commits #172
Merged
Restore lost commits #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get some Transfer events where 0 is actually transferred. We show these in decodings and logs, but we will now not show them in the balance changes list since no balance changed.
lukanus
reviewed
Mar 25, 2024
|
|
||
| // Recover from any panics. Should be the last deferred call so it runs | ||
| // first. | ||
| defer func() { |
There was a problem hiding this comment.
Where do we expect any panics to happen?
There was a problem hiding this comment.
We don't expect a panic any more than any other bugs, and all currently known vectors for a panic have been fixed, but if we ever do introduce or find a panic it's preferable to recover instead of allowing the process to crash. Crashing is expensive in terms of time to start up and re-peer so clients can't immediately reconnect like they can with other websocket failures.
|
Merged as separate commits to preserve fixes history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commits were made to
mainand didn't get into themempool-feed-stagebranch. This PR brings over my functionality-related changes that weren't re-added in other PRs.