Make Option's function lazy, deprecate the eager version #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwmyers
requested review from
Synesso,
hugomd and
millyrowboat
as code owners
Synesso
reviewed
Oct 30, 2023
Synesso
approved these changes
Oct 30, 2023
|
Remember to update the changelog. & We should remember to bump the minor version for a breaking change. |
cwmyers
changed the title
hugomd
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings
Optionin line withEither's version see: https://github.com/cashapp/quiver/blob/9862a2af9c6000e12d07bf8fb8d158a21ebd9aa7/lib/src/main/kotlin/app/cash/quiver/extensions/Either.kt#L34It would be expected behaviour to not have all the alternatives for the
orto execute until it is actually needed, especially if there is an expensive side-effect involved.