backport traverse functions on NonEmptyList #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparkersquare
requested review from
Synesso,
hugomd,
cwmyers and
millyrowboat
as code owners
aparkersquare
changed the title
aparkersquare
force-pushed
the
aparker/20230905-backport-deprecated-traverse-functions
branch
from
84c394b
to
0469b9f
Compare
hugomd
reviewed
Sep 7, 2023
| @OptIn(ExperimentalTypeInference::class) | ||
| @OverloadResolutionByLambdaReturnType | ||
| inline fun <E, A, B> Nel<A>.traverse(f: (A) -> Either<E, B>): Either<E, NonEmptyList<B>> = | ||
| let { nel -> either { nel.map { f(it).bind() } } } |
There was a problem hiding this comment.
Is let required here because the either computation re-scopes this?
There was a problem hiding this comment.
Yes, we need to give the NonEmptyList this a name.
aparkersquare
force-pushed
the
aparker/20230905-backport-deprecated-traverse-functions
branch
from
0469b9f
to
de17cff
Compare
aparkersquare
deleted the
aparker/20230905-backport-deprecated-traverse-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extension functions for
traversetoNonEmptyListthat are deprecated in Arrow.traverseEitherandtraverseEitheracross the contents of the NonEmptyListNonEmptyList<A>.traverse(f: (A) -> Either<E, B>): Either<E, NonEmptyList<B>traverseOptionandtraverseOptionacross the contents of the NonEmptyListNonEmptyList<A>.traverse(f: (A) -> Option<B>): Option<NonEmptyList<B>>