-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traverse, zip and orEmpty to Option #53
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,10 @@ | ||||||
package app.cash.quiver.extensions | ||||||
|
||||||
import arrow.core.None | ||||||
import arrow.core.right | ||||||
import arrow.core.some | ||||||
import io.kotest.assertions.arrow.core.shouldBeRight | ||||||
import io.kotest.assertions.arrow.core.shouldBeSome | ||||||
import io.kotest.core.spec.style.StringSpec | ||||||
import io.kotest.matchers.shouldBe | ||||||
import io.kotest.property.Arb | ||||||
|
@@ -29,4 +32,24 @@ class OptionTest : StringSpec({ | |||||
None.or(other) shouldBe other | ||||||
} | ||||||
} | ||||||
|
||||||
"traverse returns an either of option" { | ||||||
"apple".some().traverseOp { | ||||||
it.length.right() | ||||||
} shouldBeRight (5.some()) | ||||||
} | ||||||
|
||||||
"zip returns an optional combination of optional values" { | ||||||
5.some().zipOp("apple".some()) { a: Int, b: String -> | ||||||
b.length * a | ||||||
} shouldBeSome 25 | ||||||
} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the indent on line 46 is actually correct (2). But the following two tests have incorrect indent (4). |
||||||
|
||||||
"orEmpty returns an empty string if used on a None" { | ||||||
None.orEmpty { "I am an useless string " } shouldBe "" | ||||||
} | ||||||
|
||||||
"orEmpty returns the string supplied if value is Some" { | ||||||
"apple".some().orEmpty { "I wanna eat $it" } shouldBe "I wanna eat apple" | ||||||
} | ||||||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate we have to use
traverseOp
andzipOp
, that really reduces the value of back-porting these.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traverseEither
andzipOption
would be more consistent with the variants onNonEmptyList
(which have recently been back-ported toquiver
).We could then add
traverse
andzip
whenarrow
finally removes them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like using straight
traverse
andzip
is worth the wait. Let's lean on Arrow to fully remove them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'll open a new PR with just
orEmpty
then if you're happy with it