chore: validate that the deployment key is always set on deployments (#…

…4250)

backend/schemaservice/controllerstate_test.go

@@ -23,8 +23,15 @@ func TestDeploymentState(t *testing.T) {
 
 	deploymentKey := key.NewDeploymentKey("test-deployment")
 	err = cs.Publish(ctx, &schema.DeploymentCreatedEvent{
-		Key:    deploymentKey,
-		Schema: &schema.Module{Name: "test"},
+		Key: deploymentKey,
+		Schema: &schema.Module{
+			Name: "test",
+			Runtime: &schema.ModuleRuntime{
+				Deployment: &schema.ModuleRuntimeDeployment{
+					DeploymentKey: deploymentKey,
+				},
+			},
+		},
 	})
 	assert.NoError(t, err)
 	view, err = cs.View(ctx)

common/schema/events.go

@@ -1,6 +1,7 @@
 package schema
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/alecthomas/types/optional"
@@ -40,6 +41,9 @@ type DeploymentCreatedEvent struct {
 func (r *DeploymentCreatedEvent) event() {}
 
 func (r *DeploymentCreatedEvent) Validate() error {
+	if r.Schema.GetRuntime().GetDeployment().GetDeploymentKey().IsZero() {
+		return fmt.Errorf("deployment key is required")
+	}
 	return nil
 }