Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Enable full JS object serialization/deserialization for queries/mutations by integrating superjson #827

Merged
merged 10 commits into from
Aug 4, 2020

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Aug 3, 2020

Closes: blitz-js/legacy-framework#669
Closes: blitz-js/legacy-framework#695

What are the changes and their implications?

Integrate superjson for full serialization and deserialization of RPC data!!

This adds a new meta object to the top level RPC protocol. The full payload is now:

{
  result: { .. data .. },
  error: null,
  meta: {
    result: { .. result meta data .. },
    error:  { .. error meta data (future) .. }
  }
}

Checklist

  • Tests added for changes - changes covered by existing tests
  • PR submitted to blitzjs.com for any user facing changes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2020

Size Change: +307 B (0%)

Total Size: 171 kB

Filename Size Change
packages/core/dist/core.cjs.development.js 9.9 kB +83 B (0%)
packages/core/dist/core.cjs.production.min.js 5.77 kB +41 B (0%)
packages/core/dist/core.esm.js 9.54 kB +81 B (0%)
packages/server/dist/server.cjs.development.js 18.8 kB +43 B (0%)
packages/server/dist/server.cjs.production.min.js 10.8 kB +23 B (0%)
packages/server/dist/server.esm.js 18.8 kB +36 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 14.3 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.09 kB 0 B
packages/display/dist/display.cjs.production.min.js 587 B 0 B
packages/display/dist/display.esm.js 961 B 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.42 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 2.69 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.27 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 14.5 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 8.71 kB 0 B
packages/generator/dist/generator.esm.js 14.2 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/generator/dist/templates/app/blitz.config.js 233 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.72 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.15 kB 0 B
packages/installer/dist/installer.esm.js 7.57 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.74 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.01 kB 0 B
packages/repl/dist/repl.esm.js 1.62 kB 0 B
packages/server/dist/index.js 142 B 0 B

compressed-size-action

@flybayer flybayer marked this pull request as ready for review August 3, 2020 23:51
@flybayer flybayer requested a review from ryardley as a code owner August 3, 2020 23:51
merelinguist
merelinguist previously approved these changes Aug 4, 2020
Skn0tt
Skn0tt previously approved these changes Aug 4, 2020
@flybayer flybayer dismissed stale reviews from Skn0tt and merelinguist via 6807aa7 August 4, 2020 14:13
@flybayer flybayer changed the title Integrate superjson! Enable full JS object serialization/deserialization for queries/mutations by integrating superjson Aug 4, 2020
@flybayer flybayer merged commit 9005c58 into canary Aug 4, 2020
@flybayer flybayer deleted the sj branch August 4, 2020 17:17
@itsdillon itsdillon changed the title Enable full JS object serialization/deserialization for queries/mutations by integrating superjson [legacy-framework] Enable full JS object serialization/deserialization for queries/mutations by integrating superjson Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants