[legacy-framework] Add loading progress indicator to blitz console
#1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseRFelix
changed the title
|
Sweet, thanks! This will definitely help some |
flybayer
changed the title
blitz console
ntgussoni
added a commit
to ntgussoni/blitz
that referenced
this pull request
Feb 7, 2021
* 'canary' of https://github.com/blitz-js/blitz: (43 commits) v0.25.0-canary.0 docs: add nemesv as a contributor (blitz-js#1373) Fix `blitz db seed` not working (blitz-js#1363) docs: add sirmyron as a contributor (blitz-js#1361) Added useMemo call for response from useRouter (blitz-js#1352) Fix your jest tests failing because of useQuery error message (blitz-js#1357) docs: add markhaehnel as a contributor (blitz-js#1360) Fix blitz CLI not using proper exit codes (blitz-js#1316) docs: add dulcehc as a contributor (blitz-js#1359) (newapp) Add incremental:true to tsconfig.json (blitz-js#1350) Add @zanedb as a contributor docs: add nksaraf as a contributor (blitz-js#1358) Fix db.connect error when using without prisma (blitz-js#1342) Adds test to assert useMutation validation (blitz-js#1351) (newapp) Fix tests not found if app has blitz in the name (blitz-js#1355) Add setQueryData to react-query-utils AND rename mutate to setQueryData (blitz-js#1291) Fix error stack trace regression by upgrading tslog: 2.9.0 → 2.9.1 (patch) (blitz-js#1348) Upgrade superjson: 1.2.3 → 1.3.0 (blitz-js#1347) v0.24.3 Add loading progress indicator to `blitz console` (blitz-js#1336) ...
itsdillon
changed the title
blitz consoleblitz console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns: #1098
What are the changes and their implications?
Changes
This PR aims to improve the UX for users when opening the Blitz console by waiting until all modules are loaded before showing the prompt. This won't solve the underlying issue with slow loading. However, it will allow the user to know when he can begin typing and improve the user experience quality.
Since this doesn't solve the underlying issue, I'm open to possible solutions for improving loading times.
Demo
Checklist