Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol/localstatequery): Added unit test function to validate GenesisConfigResult #947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arepala-uml
Copy link

  1. Added a unit test function to validate GenesisConfigResult in protocol/localstatequery.
  2. Added marshal/unmarshal this GenesisConfigResult to/from JSON to ensure it's fixed.

Closes #584

…idate GenesisConfigResult

Signed-off-by: Akhil Repala <arepala@blinklabs.io>
@arepala-uml arepala-uml marked this pull request as ready for review March 11, 2025 14:50
@arepala-uml arepala-uml requested a review from a team as a code owner March 11, 2025 14:50
// This value contains maps with bytestring keys, which we can't parse yet
GenDelegs cbor.RawMessage
Unknown1 interface{}
Unknown2 interface{}
}

type ProtocolParams struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to remove ambiguity, let's name this something like GenesisConfigResultProtocolParameters.

This is really just shelley.ShelleyProtocolParameters, but we can't use that as a drop-in replacement (it's missing MinPoolCost, because reasons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenesisConfigResult in protocol/localstatequery fails to unmarshal to JSON
2 participants