Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement handshake refusal #32

Closed
agaffney opened this issue Mar 3, 2022 · 0 comments · Fixed by #426
Closed

Implement handshake refusal #32

agaffney opened this issue Mar 3, 2022 · 0 comments · Fixed by #426

Comments

@agaffney
Copy link
Contributor

agaffney commented Mar 3, 2022

We currently can't properly cope when there are no matching versions in the handshake when acting as a server. This will require figuring out the various refusal reasons (we have consts for their IDs) and how they are formatted, and adding checks for those cases.
@agaffney agaffney mentioned this issue Nov 10, 2023
Closed
agaffney added a commit that referenced this issue Nov 14, 2023
@agaffney
feat: handshake server-side refusal
07bf5a5 
Fixes #32 and #39
agaffney added a commit that referenced this issue Nov 14, 2023
@agaffney
feat: handshake server-side refusal
4a8ae15 
Fixes #32 and #39
agaffney added a commit that referenced this issue Nov 14, 2023
@agaffney
feat: handshake server-side refusal
78b674a 
Fixes #32 and #39
agaffney added a commit that referenced this issue Nov 14, 2023
@agaffney
feat: handshake server-side refusal
74fb777 
Fixes #32 and #39
@agaffney agaffney mentioned this issue Nov 14, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in go-ouroboros-network Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handshake server-side refusal blinklabs-io/gouroboros
1 participant
@agaffney