fix: connection.BlockFetch().Client.GetBlock potential deadlock (#787)

blinklabs-io · Nov 11, 2024 · 9a80cbd · 9a80cbd
1 parent 490f039
commit 9a80cbd
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/protocol/blockfetch/client.go b/protocol/blockfetch/client.go
@@ -164,6 +164,7 @@ func (c *Client) GetBlock(point common.Point) (ledger.Block, error) {
 	}
 	err, ok := <-c.startBatchResultChan
 	if !ok {
+		c.busyMutex.Unlock()
 		return nil, protocol.ProtocolShuttingDownError
 	}
 	if err != nil {
@@ -172,6 +173,7 @@ func (c *Client) GetBlock(point common.Point) (ledger.Block, error) {
 	}
 	block, ok := <-c.blockChan
 	if !ok {
+		c.busyMutex.Unlock()
 		return nil, protocol.ProtocolShuttingDownError
 	}
 	return block, nil