Skip to content

Commit

Permalink
chore: add issues to TODO comments
Browse files Browse the repository at this point in the history
Signed-off-by: Aurora Gaffney <aurora@agaffney.org>
  • Loading branch information
agaffney committed Feb 5, 2025
1 parent 25fc7e4 commit f43c42b
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,6 @@ func accessLogger(param gin.LogFormatterParams) string {
}

func handleHealthcheck(c *gin.Context) {
// TODO: add some actual health checking here
// TODO: add some actual health checking here (#337)
c.JSON(200, gin.H{"failed": false})
}
2 changes: 1 addition & 1 deletion api/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ func TestRouteRegistration(t *testing.T) {
assert.Equal(t, http.StatusNotFound, rr.Code, "Expected status not found")

// You can also check the response body, headers, etc.
// TODO check for JSON response
// TODO check for JSON response (#338)
// assert.Equal(t, `{"fcmToken":"someToken"}`, rr.Body.String())
}
2 changes: 1 addition & 1 deletion filter/chainsync/chainsync.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func New(options ...ChainSyncOptionFunc) *ChainSync {
// Start the chain sync filter
func (c *ChainSync) Start() error {
go func() {
// TODO: pre-process filter params to be more useful for direct comparison
// TODO: pre-process filter params to be more useful for direct comparison (#336)
for {
evt, ok := <-c.inputChan
// Channel has been closed, which means we're shutting down
Expand Down
1 change: 0 additions & 1 deletion filter/event/event.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func New(options ...EventOptionFunc) *Event {
// Start the event filter
func (e *Event) Start() error {
go func() {
// TODO: pre-process filter params to be more useful for direct comparison
for {
evt, ok := <-e.inputChan
// Channel has been closed, which means we're shutting down
Expand Down
2 changes: 1 addition & 1 deletion output/push/fcm_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type ErrorResponse struct {
Error string `json:"error"`
}

// TODO add support for persistence
// TODO add support for persistence (#335)
var fcmStore *TokenStore

func init() {
Expand Down
2 changes: 1 addition & 1 deletion output/webhook/webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (w *WebhookOutput) Start() error {
logger.Error(fmt.Sprintf("unknown event type: %s", evt.Type))
return
}
// TODO: error handle
// TODO: error handle (#334)
err := w.SendWebhook(&evt)
if err != nil {
logger.Error(fmt.Sprintf("ERROR: %s", err))
Expand Down

0 comments on commit f43c42b

Please sign in to comment.