remove plugin method #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than have a method Plugin() which returns a value
implementing the interface (typed as segment.Plugin)
the code (in scorch) registering this version can instead
simply use &zapv15.ZapPlugin{} which satisfies the interface
this more naturally follows the Go convention of consumers
defining the interface they need to work with, and it
further simplifies the segment api package
sreekanth-cb
approved these changes
Dec 1, 2020
abhinavdangeti
added a commit
that referenced
this pull request
Nov 10, 2023
To absorb: * 0ea762e Abhi Dangeti | Temporarily revert free-ing C pointers/buffers - adding a TODO for this (#7)
abhinavdangeti
added a commit
that referenced
this pull request
Nov 10, 2023
To absorb: * 0ea762e Abhi Dangeti | Temporarily revert free-ing C pointers/buffers - adding a TODO for this (#7)
moshaad7
pushed a commit
that referenced
this pull request
Sep 12, 2024
To absorb: * 0ea762e Abhi Dangeti | Temporarily revert free-ing C pointers/buffers - adding a TODO for this (#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than have a method Plugin() which returns a value
implementing the interface (typed as segment.Plugin)
the code (in scorch) registering this version can instead
simply use &zapv15.ZapPlugin{} which satisfies the interface
this more naturally follows the Go convention of consumers
defining the interface they need to work with, and it
further simplifies the segment api package