MB-56946: update analyzer interface and registry #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshaad7
changed the title
moshaad7
force-pushed
the
MB-56946_UDA
branch
from
ecd2278
to
abeee2c
Compare
moshaad7
changed the title
moshaad7
changed the title
+ Update Analyzer interface to + handle errors produced during analysis. + use "any" as return type of Analysis (generating values other than tokenStream, like embedding vectors) + Update the analyzers registry to allow runtime registration/removal + This is to let bleve users register/deregister analyzers at runtime and use it in their index mappings NOTE: This will break backward compatibility for bleve customers registering their own analyzer implementations.
moshaad7
force-pushed
the
MB-56946_UDA
branch
from
abeee2c
to
c452e11
Compare
moshaad7
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Analyzer interface to
Update the analyzers registry to allow runtime registration/removal
NOTE:
This will break backward compatibility for bleve users who register their own analyzer implementations.