Updating SingleSegmentMergePlanOptions with MaxSegmentFileSize #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
metonymic-smokey
approved these changes
Jul 9, 2024
CascadingRadium
approved these changes
Jul 9, 2024
abhinavdangeti
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small oversight introduced in force merge paths, where
MaxSegmentFileSizeoption was missing in theSingleSegmentMergePlanOptions. This lead to none of the segments being eligible for a force merge. (bleve/index/scorch/mergeplan/merge_plan.go
Line 189 in 0672efa
Consequently I was observing that the force merge was a no op when I triggered the API. Currently, this value has been set to 1TB.