MB-59616: Adding vector_base64 field #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Likith101
commented
Apr 10, 2024
Likith101
commented
- Added a new field type called vector_base64.
- Acts similar to vector in most cases.
- When a new document arrives in the bleve layer, during the parsing of all its fields in processProperty, if the field mapping type is vector-base64, then its value is decoded into a vector field and processed like a vector.
- The standard golang base64 library is used for the decode operation.
- Added a new field type called vector_base64. - Acts similar to vector in most cases. - When a new document arrives in the bleve layer, during the parsing of all its fields in processProperty, if the field mapping type is vector-base64, then its value is decoded into a vector field and processed like a vector. - The standard golang base64 library is used for the decode operation.
- Added VectorBase64 of type string to the KNNRequest struct - ValidateKNN will handle the decoding of the encoded string and fill the vector field with the vector value
Likith101
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
moshaad7
abhinavdangeti
requested changes
Apr 10, 2024
abhinavdangeti
requested changes
Apr 12, 2024
abhinavdangeti
requested changes
Apr 15, 2024
There was a problem hiding this comment.
@Likith101 looking mostly ready. Would you add a benchmark test to here that tests time taken for DecodeVector(..) for a few dimensionalities - maybe 128, 784, 1536.
Thejas-bhat
reviewed
Apr 15, 2024
|
@Likith101 faiss_vector_base64_test.go should also get the |
|
@Likith101 Did you already run the decode algorithm by Jon? |
I ran the decode algorithm by Jon, so no changes necessary there. |
|
These are the benchmark results for the decode function done on my local system.
|
abhinavdangeti
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.