Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spanish accents normalization #1957

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

svera
Copy link
Contributor

@svera svera commented Jan 8, 2024

Normalization of accented letters only happens if the input is larger than 5 characters, something that, for example, neither guía nor fría comply.
The solution would be to always execute the accented characters normalization, by moving it to a separate file just like it is done in the german analyzer.

Fixes: #1956

Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @svera , let's wait on one more review possibly.

@abhinavdangeti abhinavdangeti merged commit 5f1f45a into blevesearch:master Jan 10, 2024
9 checks passed
abhinavdangeti added a commit that referenced this pull request Feb 13, 2024
```
* 5c7445c Abhinav Dangeti | Fix merge conflict
*   a0cb65a Abhinav Dangeti | Merge remote-tracking branch 'origin/master' into 7.6-couchbase
|\
| * 5f1f45a Sergio Vera | Fixed spanish accents normalization (#1957)
| * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946)
| * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898)
| * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905)
| * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
* | 8b9206a Abhi Dangeti | MB-60739: Upgrade go-faiss & zapx/v16 (#1985)
```
@abhinavdangeti abhinavdangeti added this to the v2.4.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Spanish analyzer not normalizing all accented words.
2 participants