Correcting bytes read value with respect to metadata loading #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- because there is a method receiving struct by value rather than reference. this causes a read/write problem just because pass by value causes a read on the shared variable when there are writes elsewhere.
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey and
moshaad7
index/scorch/snapshot_segment.go
Outdated
| // segment was mmaped recently, in which case | ||
| // we consider the loading cost of the metadata | ||
| // as part of IO stats. | ||
| mmaped uint64 |
There was a problem hiding this comment.
Move this to be the first attribute of this struct. Also, a uint32 would suffice?
There was a problem hiding this comment.
yeah it's sufficient, will do.
index/scorch/merge.go
Outdated
| @@ -429,6 +430,7 @@ type segmentMerge struct { | |||
| oldNewDocNums map[uint64][]uint64 | |||
| new segment.Segment | |||
| notifyCh chan *mergeTaskIntroStatus | |||
| mmaped bool | |||
There was a problem hiding this comment.
I'd rather we keep the type of this variable as uint for consistency.
abhinavdangeti
approved these changes
Dec 7, 2022
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Dec 15, 2022
For fix: blevesearch/bleve#1769 Change-Id: I57d39397a96412f770073c0653d1e68076500b70 Reviewed-on: https://review.couchbase.org/c/cbft/+/184147 Well-Formed: Build Bot <build@couchbase.com> Reviewed-by: Sitaram Vemulapalli <sitaram.vemulapalli@couchbase.com> Tested-by: Abhi Dangeti <abhinav@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.