MB-40604: Support IPRange query #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: #1546
Thejas-bhat
reviewed
Oct 7, 2022
search_test.go
Outdated
| } | ||
| }() | ||
|
|
||
| ipContent := "1.2.3.4" |
There was a problem hiding this comment.
A small doubt, do you think we can use a dummy (but a more realistic) IP address over here as an example?
Thejas-bhat
approved these changes
Oct 10, 2022
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Jan 18, 2023
+ IP field support introduced with:
blevesearch/bleve#1546
+ Also, requires:
blevesearch/bleve#1735
Change-Id: I76cc275ebc7817ecec0521789587c1b68eeafdd9
Reviewed-on: https://review.couchbase.org/c/cbft/+/179981
Well-Formed: Build Bot <build@couchbase.com>
Tested-by: Abhi Dangeti <abhinav@couchbase.com>
Reviewed-by: <thejas.orkombu@couchbase.com>
abhinavdangeti
added a commit
that referenced
this pull request
Jan 19, 2023
* MB-40604: Support IPRange query Related: #1546 * Update IPs used in TestIPRangeQuery
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Jan 20, 2023
+ Uses `7.2-couchbase` branch of blevesearch/bleve
which includes the following commit over v2.3.3:
- blevesearch/bleve#1735
+ IP field and RangeQuery support added with:
- blevesearch/bleve#1546
- blevesearch/bleve#1735
Change-Id: I76cc275ebc7817ecec0521789587c1b68eeafdd9
Reviewed-on: https://review.couchbase.org/c/cbft/+/185273
Well-Formed: Restriction Checker
Tested-by: Abhi Dangeti <abhinav@couchbase.com>
Reviewed-by: Abhi Dangeti <abhinav@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1546