new FormatSpecifier option for FieldMapping #1430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new FormatSpecifier option allows us to convert numeric values into strings suitable for indexing in a text field. Format specifiers are relatively limited, but do allow for basic conversion, as well as fixed width padding.
abhinavdangeti
approved these changes
Jul 27, 2020
| @@ -59,6 +59,8 @@ type FieldMapping struct { | |||
| // DocValues, if true makes the index uninverting possible for this field | |||
| // It is useful for faceting and sorting queries. | |||
| DocValues bool `json:"docvalues,omitempty"` | |||
|
|
|||
| FormatSpecifier string `json:"format_specifier,omitempty"` | |||
There was a problem hiding this comment.
Some commentary here that "%f" is the thing to use for correct translation of numeric (float) values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new FormatSpecifier option allows us to convert numeric
values into strings suitable for indexing in a text field.
Format specifiers are relatively limited, but do allow for basic
conversion, as well as fixed width padding.