AddMany instead of Add to a bitmap

blevesearch · Oct 15, 2024 · 7404155 · 7404155
1 parent 3c77b49
commit 7404155
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/index/scorch/snapshot_index_vr.go b/index/scorch/snapshot_index_vr.go
@@ -64,11 +64,16 @@ type IndexSnapshotVectorReader struct {
 // (AND) operations. Eg. finding the eligible doc IDs present in a segment.
 func (i *IndexSnapshotVectorReader) getEligibleDocIDs() *roaring.Bitmap {
 	res := roaring.NewBitmap()
+	internalDocIDs := make([]uint32, 0, len(i.eligibleDocIDs))
 	// converts the doc IDs to uint32 and returns
 	for _, eligibleDocInternalID := range i.eligibleDocIDs {
-		internalDocID, _ := docInternalToNumber(index.IndexInternalID(eligibleDocInternalID))
-		res.Add(uint32(internalDocID))
+		internalDocID, err := docInternalToNumber(index.IndexInternalID(eligibleDocInternalID))
+		if err != nil {
+			continue
+		}
+		internalDocIDs = append(internalDocIDs, uint32(internalDocID))
 	}
+	res.AddMany(internalDocIDs)
 	return res
 }