Integrate frontend with new stoploss contract #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yvesfracari
changed the title
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
src/lib/tooltipDescriptions.ts
Outdated
| MAX_TIME_SINCE_LAST_ORACLE_UPDATE = "The maximum time since the last oracle update. If the oracle has not been updated in this time, the order will not be executed.", | ||
| TYPE = "The order can be fill or kill (entire order must be filled) or partial fill (part of the order can be filled respecting the limit price).", | ||
| VALID_TO = "The date and time at which the order will expire if not filled.", | ||
| VALID_TO_INPUT = "The time at which the order can be filled. After this time, the order will expire. This not take into account the transaction signing time.", |
There was a problem hiding this comment.
Suggested change
| VALID_TO_INPUT = "The time at which the order can be filled. After this time, the order will expire. This not take into account the transaction signing time.", | |
| VALID_TO_INPUT = "The absolute date and time before which the order can be filled. After this time, the order will expire.", |
There was a problem hiding this comment.
Actually this input is a select with time periods (6 months, 1 month, etc). Think that your suggestion would be better for a exact time. What you say about
How long the order will be valid and can be filled starting now. After this, the order will expire.
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
ribeirojose
reviewed
Jul 23, 2024
yvesfracari
deleted the
pedro/cow-325-integrate-validto-parameter-on-frontend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate order creation
Integrate new ponder api