Skip to content

Commit

Permalink
standardize copy: use Receiver instead of Recipient
Browse files Browse the repository at this point in the history
  • Loading branch information
ribeirojose committed Jul 19, 2024
1 parent 51384fa commit 5ba7adc
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/components/AdvancedSettingsDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function AdvancedSettingsDialog() {
name="receiver"
label="Receiver"
placeholder="0xabc...123"
tooltipText={TOOLTIP_DESCRIPTIONS.RECIPIENT}
tooltipText={TOOLTIP_DESCRIPTIONS.RECEIVER}
extraLabelElement={
<BlockExplorerLink
type="address"
Expand Down
4 changes: 2 additions & 2 deletions src/components/OrderDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ export function OrderDetails({
{maxOracleUpdateTime}
</OrderDetailsInformation>
<OrderDetailsInformation
label="Recipient"
tooltipText={TOOLTIP_DESCRIPTIONS.RECIPIENT}
label="Receiver"
tooltipText={TOOLTIP_DESCRIPTIONS.RECEIVER}
>
<div className="flex items-center gap-x-1">
{order?.stopLossData?.to}
Expand Down
2 changes: 1 addition & 1 deletion src/components/ReviewOrdersDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ function OrderContent({ order }: { order: DraftOrder }) {
</OrderInformation>
<OrderInformation
title="Receiver"
tooltipText={TOOLTIP_DESCRIPTIONS.RECIPIENT}
tooltipText={TOOLTIP_DESCRIPTIONS.RECEIVER}
>
<AddressWithLink address={order.receiver} />
</OrderInformation>
Expand Down
2 changes: 1 addition & 1 deletion src/components/TxPendingDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function TxPendingDialog() {
>
<div className="flex flex-col gap-2 w-full">
<DialogTitle className="text-2xl font-medium ">
Transaction pending
Submitted
</DialogTitle>
<span className="text-wrap">
{isPonderUpdating ? "Almost done" : "Done"}!
Expand Down
4 changes: 3 additions & 1 deletion src/components/data-table/data-table-toolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ interface DataTableToolbarProps<TData>
extends React.HTMLAttributes<HTMLDivElement> {
table: Table<TData>;
filterFields?: DataTableFilterField<TData>[];
showDataTableViewOptions?: boolean;
}

export function DataTableToolbar<TData>({
table,
filterFields = [],
children,
className,
showDataTableViewOptions = false,
...props
}: DataTableToolbarProps<TData>) {
const isFiltered = table.getState().columnFilters.length > 0;
Expand Down Expand Up @@ -90,7 +92,7 @@ export function DataTableToolbar<TData>({
</div>
<div className="flex items-center gap-2">
{children}
<DataTableViewOptions table={table} />
{showDataTableViewOptions && <DataTableViewOptions table={table} />}
</div>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/tooltipDescriptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export enum TOOLTIP_DESCRIPTIONS {
STATUS = "The status can be open, filled, partially filled or cancelled.",
SUBMISSION_TIME = "The date and time at which the order was submitted.",
VALIDITY_BUCKET_TIME = "After the oracle price achieves the defined trigger price, how much time the order will wait to be filled on the orderbook.",
RECIPIENT = "Recipient address that will receive the buy tokens of the order.",
RECEIVER = "Receiver address that will receive the buy tokens of the order.",
AMOUNT = "The total sell and buy amount for this order. Sell amount includes the fee.",
EXECUTION_PRICE = "The actual price at which this order has been matched and executed, after deducting fees from the amount sold.",
ORDER = "The amount sold/bought. Also surplus for this order. This is the positive difference between the initial limit price and the actual (average) execution price.",
Expand Down

0 comments on commit 5ba7adc

Please sign in to comment.