feat(components): refactor components and remove tailwind prefix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirojose
reviewed
Jan 22, 2024
| case "boolean": | ||
| return ( | ||
| <Badge variant={value ? "default" : "secondary"}> | ||
| {value ? "True" : "False"} |
There was a problem hiding this comment.
😬 this is a bit odd, right? I'd even use emojis ❌ and ✅ instead of True and False strings. I think only technical users would digest that 😅
ribeirojose
reviewed
Jan 22, 2024
| encType?: string; | ||
| method?: "post" | "get"; | ||
| }) => { | ||
| // const csrfToken = ReactOnRails.authenticityToken(); | ||
| const csrfToken = useRailsApp(); |
There was a problem hiding this comment.
#would try to not make this mandatory here so that we could use this project in bleu's nextjs projects as well
ribeirojose
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM.
As a note, I don't think we needed a separate task for this as it was part of your other tasks.
Also, I sent 1ff1b4d
devjoaov
changed the title
ribeirojose
deleted the
joao/click-565-update-bleu-ui-tailwind-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.