Add disable property to input and select field #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirojose
reviewed
Mar 14, 2024
| @@ -56,6 +56,7 @@ export const InputField = withConditional<InputFieldProps>( | |||
| <Input | |||
| placeholder={field.placeholder} | |||
| {...formField} | |||
| disabled={field.disabled ? (field.disabled as boolean) : false} | |||
There was a problem hiding this comment.
is it not boolean by default in the type? 😬 it should be disabled?: boolean. this could be written as field.disabled ?? false
There was a problem hiding this comment.
right now
disabled?: boolean | ((data: FieldValues) => boolean);
and with this I get
Type 'boolean | ((data: FieldValues) => boolean)' is not assignable to type 'boolean | undefined'.
Type '(data: FieldValues) => boolean' is not assignable to type 'boolean | undefined'.ts(2322)
Saw we do this on SwitchField
const disabled =
typeof field.disabled === "function"
? field.disabled(form.getValues())
: field.disabled;
ribeirojose
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.