Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SWRDataTable filters to query params #19

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

devjoaov
Copy link
Contributor

@devjoaov devjoaov commented Feb 9, 2024

No description provided.

Copy link

linear bot commented Feb 9, 2024

CLICK-610

@devjoaov devjoaov changed the title listagem de teses add SWRDataTable filters to query params Feb 9, 2024
@devjoaov devjoaov self-assigned this Feb 9, 2024
Copy link
Contributor

@ribeirojose ribeirojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great stuff.

"pageIndex": "0",
"pageSize": "10"
* }
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc 👍


/**
* This function takes a query string and converts it into an object.
* It follows the Rails pattern for nested query parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@@ -28,5 +98,26 @@ export function serializeQuery(params, prefix) {
return `${key}=${encodeURIComponent(value)}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that the key also needs to be encoded?

@ribeirojose ribeirojose merged commit e5c3dda into main Feb 9, 2024
2 checks passed
@ribeirojose ribeirojose deleted the joao/click-610-listagem-de-teses-gerais branch February 9, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants