Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: os.platform() == 'windows' will never match #6

Closed
dhermes opened this issue Feb 9, 2022 · 0 comments
Closed

Bug: os.platform() == 'windows' will never match #6

dhermes opened this issue Feb 9, 2022 · 0 comments
Assignees
@dhermes

Comments

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2022

https://nodejs.org/docs/latest-v16.x/api/os.html#osplatform

Returns a string identifying the operating system platform. The value is set at compile time. Possible values are 'aix', 'darwin', 'freebsd', 'linux', 'openbsd', 'sunos', and 'win32'.
@dhermes dhermes self-assigned this Feb 9, 2022
dhermes pushed a commit that referenced this issue Feb 9, 2022
Fixing Node.js Windows value for os.platform().
4b7de50 
I assumed it was the same as `GOOS` (`windows`) but the docs for
Node.js say otherwise (`win32`):
https://nodejs.org/docs/latest-v16.x/api/os.html#osplatform

Fixes #6.
@dhermes dhermes closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhermes