[types][flow] Fix invertase#1205

blankg · Jan 15, 2019 · 035d6c8 · 035d6c8
1 parent f8e7839
commit 035d6c8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/src/modules/firestore/CollectionReference.js b/src/modules/firestore/CollectionReference.js
@@ -38,7 +38,7 @@ export default class CollectionReference {
     return this._firestore;
   }
 
-  get id(): string | null {
+  get id(): string {
     return this._collectionPath.id;
   }
 

diff --git a/src/modules/firestore/DocumentReference.js b/src/modules/firestore/DocumentReference.js
@@ -46,7 +46,7 @@ export default class DocumentReference {
     return this._firestore;
   }
 
-  get id(): string | null {
+  get id(): string {
     return this._documentPath.id;
   }
 

diff --git a/src/modules/firestore/DocumentSnapshot.js b/src/modules/firestore/DocumentSnapshot.js
@@ -48,7 +48,7 @@ export default class DocumentSnapshot {
     return this._data !== undefined;
   }
 
-  get id(): string | null {
+  get id(): string {
     return this._ref.id;
   }
 

diff --git a/src/modules/firestore/Path.js b/src/modules/firestore/Path.js
@@ -13,8 +13,9 @@ export default class Path {
     this._parts = pathComponents;
   }
 
-  get id(): string | null {
-    return this._parts.length ? this._parts[this._parts.length - 1] : null;
+  get id(): string {
+    // TODO is length check required?
+    return this._parts.length ? this._parts[this._parts.length - 1] : '';
   }
 
   get isDocument(): boolean {