Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Missing username validation in SignInForm #20

Closed
blahosyl opened this issue Jul 30, 2024 · 3 comments
Closed

BUG: Missing username validation in SignInForm #20

blahosyl opened this issue Jul 30, 2024 · 3 comments
Labels
bug Something isn't working p: could have Priority: Nice to have
Milestone
Sprint 2: CRUD & ...

Comments

@blahosyl
Copy link
Owner

The SignInForm does not give an error message when the username is empty. This issue already exists in the Moments walkthough project.

Image
@blahosyl blahosyl moved this to Blocked in Task Manager Jul 30, 2024
@blahosyl blahosyl added bug Something isn't working help wanted Extra attention is needed blocked Waiting for input or for another work phase to finish labels Jul 30, 2024
@blahosyl
Copy link
Owner Author

blahosyl commented Aug 6, 2024

From the network response, it seems this is a backend issue

Image

Image

@blahosyl blahosyl added the p: could have Priority: Nice to have label Aug 6, 2024
@blahosyl
Copy link
Owner Author

blahosyl commented Aug 6, 2024

The form cannot be submitted without a username, so this does not affect the working of the app.

Image

@blahosyl blahosyl added this to the Sprint 2: Profiles & UX milestone Aug 6, 2024
blahosyl added a commit that referenced this issue Aug 7, 2024
@blahosyl
FIX : add required to signin form fields #20
dfec85b 
suggestion by Kelly Hutchison https://github.com/quiltingcode
@blahosyl
Copy link
Owner Author

blahosyl commented Aug 7, 2024

Following a suggestion by Kelly Hutchison, I added Frontend validation by adding the required prop to the form fields.

@blahosyl blahosyl closed this as completed Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Blocked/Ongoig to Done in Task Manager Aug 7, 2024
blahosyl added a commit that referenced this issue Aug 7, 2024
@blahosyl
add code credit #10 #20
f367615
@blahosyl blahosyl removed help wanted Extra attention is needed blocked Waiting for input or for another work phase to finish labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p: could have Priority: Nice to have
Projects
Task Manager
Status: Done/Won't do
Milestone
Sprint 2: CRUD & basic views
Development

No branches or pull requests
1 participant
@blahosyl