Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check themes.js for superfluos code #114

Closed
blahosyl opened this issue Jun 16, 2024 · 0 comments
Closed

Check themes.js for superfluos code #114

blahosyl opened this issue Jun 16, 2024 · 0 comments
Assignees
@blahosyl
Labels
e: code structure & comments Epic: Code structure & comment coverage p: could have Priority: Nice to have refactoring Code refactoring without changes in functionaity
Milestone
Sprint 3: Interac...

Comments

@blahosyl
Copy link
Owner

The function checking whether storage already has something in it might not be doing anything. The functionality works now as per #98 , so changing anything requires renewed testing.
@blahosyl blahosyl added p: could have Priority: Nice to have refactoring Code refactoring without changes in functionaity labels Jun 16, 2024
@blahosyl blahosyl self-assigned this Jun 16, 2024
blahosyl added a commit that referenced this issue Jun 17, 2024
@blahosyl
eliminate superfluous code #114
634bfaa
@blahosyl blahosyl moved this to Todo in Spicy Recipes Jun 20, 2024
@blahosyl blahosyl added the e: code structure & comments Epic: Code structure & comment coverage label Jun 27, 2024
@blahosyl blahosyl moved this from Todo to Done/Won't Do in Spicy Recipes Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blahosyl blahosyl

Labels
e: code structure & comments Epic: Code structure & comment coverage p: could have Priority: Nice to have refactoring Code refactoring without changes in functionaity
Projects
Spicy Recipes
Status: Done/Won't Do
Milestone
Sprint 3: Interactivity & collaboration
Development

No branches or pull requests
1 participant
@blahosyl