Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 11 #223

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Laravel 11 #223

merged 10 commits into from
Feb 7, 2024

Conversation

robsontenorio
Copy link
Contributor

No description provided.

@driesvints
Copy link
Member

Heya. Can you also add the new test bench version and update the matrix build on the GHA?

@robsontenorio robsontenorio mentioned this pull request Jan 30, 2024
Merged
@robsontenorio
Copy link
Contributor Author

robsontenorio commented Jan 30, 2024 •
edited
Loading

Done! But it fails because v11 dependencies :(

driesvints
driesvints requested changes Jan 30, 2024
View reviewed changes
composer.json Outdated
"illuminate/contracts": "^8.0|^9.0|^10.0|^11.0",
"illuminate/filesystem": "^8.0|^9.0|^10.0|^11.0",
"illuminate/support": "^8.0|^9.0|^10.0|^11.0",
"illuminate/view": "^8.0|^9.0|^10.0|^11.0",
"symfony/console": "^5.3|^6.0",
"symfony/finder": "^5.3|^6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to add Symfony v7 constraints here as well.

Copy link
Contributor Author

@robsontenorio robsontenorio Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it! . But, the problem now is illuminate/contracts windows L11. Should I remove it?

image

@driesvints
Copy link
Member

What's weird is that the exact same build on Ubuntu does work. I'm gonna leave this open until after Laravel v11's release and then merge and tag.

@driesvints driesvints merged commit 62f3929 into blade-ui-kit:1.x Feb 7, 2024
12 checks passed
@driesvints
Copy link
Member

Is disabled the Laravel v11 windows build for now. Thanks!

@owenvoke
Copy link
Contributor

owenvoke commented Feb 7, 2024 •
edited
Loading

This might be happening because Windows treats ^ as an escape character. 🤔 If this is the issue, an alternative is to change to "illuminate/contracts=${{ matrix.laravel }}.*" 🙂 I would have thought it'd have been fine though, as it's quoted, but perhaps not.

@driesvints
Copy link
Member

@owenvoke seems that worked! #224

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robsontenorio @driesvints @owenvoke