Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for invalid defer attribute on SVG tag #218

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

Jaybuz
Copy link
Contributor

@Jaybuz Jaybuz commented Sep 22, 2023

Removes the defer attribute as it is not a valid attribute on the SVG tag.

Fixes the W3C error below:
Error: Attribute defer not allowed on element svg at this point.

@driesvints
Copy link
Member

This needs to be removed on the SVG itself.

@driesvints driesvints closed this Sep 22, 2023
@Jaybuz
Copy link
Contributor Author

Jaybuz commented Sep 22, 2023

Am I missing something? If I'm using the defer feature, it requires adding the defer attribute.

@driesvints
Copy link
Member

Hey sorry. I'll have a look as soon as I'm able.

@driesvints driesvints reopened this Sep 25, 2023
@driesvints driesvints merged commit b5e6603 into blade-ui-kit:1.x Oct 18, 2023
10 checks passed
@driesvints
Copy link
Member

Managed to find some time for this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants