Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize component attributes over set and default attributes #197

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Prioritize component attributes over set and default attributes #197

merged 2 commits into from
Aug 24, 2022

Conversation

sebastianpopp
Copy link
Contributor

I had the problem that I set stroke-width as a default attribute in my config

<?php
return [
    'attributes' => [
        'stroke-width' => '1.5',
    ],
];

while still wanting to be able to set it to a different value in a few places:

<x-icon-camera stroke-width="1" />

I think it makes sense that the attribute on the component takes priority over the default attributes.

@driesvints
Copy link
Member

Bit torn on this as it's technically a breaking change. But I agree it's the more sensible thing. Let's see how it goes.

@driesvints driesvints merged commit efa53eb into blade-ui-kit:1.x Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants