Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit dynamic from property attributes #44

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

t0rr3sp3dr0
Copy link
Contributor

@dynamic is only meant to be used inside an @implementation block, it should never appear inside @interface and @protocol blocks. This patch prevents go-macho from generating a header with that attribute.

Before:

@interface AXAuditTimedResult : NSObject

@property (retain, nonatomic) NSDate *startTime;
@property (retain, nonatomic) NSDate *endTime;
@property (readonly, @dynamic, nonatomic) NSString *executionTimeString;

@end

After:

@interface AXAuditTimedResult : NSObject

@property (retain, nonatomic) NSDate *startTime;
@property (retain, nonatomic) NSDate *endTime;
@property (readonly, nonatomic) NSString *executionTimeString;

@end

@t0rr3sp3dr0
Copy link
Contributor Author

PTAL

@blacktop blacktop merged commit 3c82901 into blacktop:master Apr 16, 2024
@t0rr3sp3dr0 t0rr3sp3dr0 deleted the t0rr3sp3dr0-patch-1 branch April 16, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants