Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nightly build version strings #2039

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

dragonmux
Copy link
Member

Detailed description

In this PR we address that the build-and-upload flow doesn't properly embed the version string associated with the build being done. This is caused by a lack of tags being pulled with the cloning process the flow uses.

This should result in all future nightly (build-and-upload) builds having the full versioning information embedded in.

Your checklist for this pull request

Closing issues

…s so that `git describe` works properly for the nightly builds to get proper version strings
@dragonmux dragonmux added Bug Confirmed bug CI Continuous Integration System labels Jan 6, 2025
@dragonmux dragonmux added this to the v2.0 release milestone Jan 6, 2025
@dragonmux dragonmux requested a review from esden January 6, 2025 01:22
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit a9df5d6 into main Jan 6, 2025
36 checks passed
@dragonmux dragonmux deleted the fix/nightly-build-version-strings branch January 6, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug CI Continuous Integration System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants