Refactor Search Frontend #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmoody
force-pushed
the
search-stimulus-controller
branch
from
62d83b0 to
aac8984
Compare
Pull Request Test Coverage Report for Build 1879672443Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jaredmoody
force-pushed
the
search-stimulus-controller
branch
3 times, most recently
from
cf199da to
94f2a7c
Compare
aidewoode
requested changes
Feb 23, 2022
jaredmoody
force-pushed
the
search-stimulus-controller
branch
3 times, most recently
from
7b9ccaa to
dd3eb66
Compare
|
OK I think I addressed everything in the comments you left, let me know if it looks good now! |
aidewoode
reviewed
Mar 8, 2022
Reduce the need for custom javascript by leveraging Turbo and HTML conventions: - By using a form, Turbo handles submission for us - Use css to handle display of loading icon
jaredmoody
force-pushed
the
search-stimulus-controller
branch
from
dd3eb66 to
15f26cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the need for custom javascript by leveraging Turbo and HTML conventions: