Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this work is with regards to handling CHAR(x) types.
MySQL has support for multi byte collations, such as utf8mb4 (4 bytes). When handling text fields, specially CHAR we should fill the column width by padding spaces to the right.
When retrieving data from binary log for example, we can extract via TME metadata from the columns, such as column size and ID of collation. The problem relies of the fact that column size is expressed in bytes taking into consideration original collation, for example, for a CHAR(2) column using UTF8MB4_0900_AI_CI the column size will be 8.
Here is one example of TME metadata and BinlogValue::Value for above example for a CHAR(2) insert of value 'A'
Currently we lack proper collation dictionary to identify Column size as character length.