fix(components/forms): ensure form error always has errorName attribute for test harnesses (#3071)
#3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute for test harnesses (#3071)
blackbaud-sky-build-user
added
the
risk level (author): 1
|
View your CI Pipeline Execution ↗ for commit 3740105.
☁️ Nx Cloud last updated this comment at |
…93b811cc_1738092877589
Blackbaud-CoreyArcher
approved these changes
Jan 29, 2025
Blackbaud-CoreyArcher
deleted the
cherry-pick_46c1e63b811c1906017ea61249fd02bd93b811cc_1738092877589
branch
johnhwhite
added a commit
that referenced
this pull request
Feb 4, 2025
🤖 I have created a release *beep* *boop* --- ## [12.0.0-alpha.3](12.0.0-alpha.2...12.0.0-alpha.3) (2025-02-04) ### ⚠ BREAKING CHANGES * **components/indicators:** remove forwarded exports from `@skyux/help-inline` and `@skyux/icon` ([#3069](#3069)) * **components/forms:** file attachment components now wait for system dialogs to close before handling files so that errors are read to screen readers appropriately ([#3073](#3073)) ### Features * add `[@docs](https://github.com/docs)IncludeIds` to action bars, tree, autonumeric, avatar, colorpicker, core, datetime, errors, flyout, and forms packages ([#3074](#3074)) ([b5747b2](b5747b2)) * add remaining `[@docs](https://github.com/docs)IncludeIds` and validation steps ([#3076](#3076)) ([cb59851](cb59851)) * **components/errors:** add error test harness ([#3082](#3082)) ([#3094](#3094)) ([4343e0a](4343e0a)) * **components/forms:** file attachment components now wait for system dialogs to close before handling files so that errors are read to screen readers appropriately ([#3073](#3073)) ([847c970](847c970)) * **components/indicators:** remove forwarded exports from `@skyux/help-inline` and `@skyux/icon` ([#3069](#3069)) ([e2e3883](e2e3883)) * **components/layout:** tokenize fluid grid styles ([#3090](#3090)) ([f7cf004](f7cf004)) * **components/tabs:** add harnesses for tab component ([#3064](#3064)) ([#3095](#3095)) ([37d2e90](37d2e90)) * **components/tiles:** add test harnesses for tile and tile dashboard ([#3052](#3052)) ([#3066](#3066)) ([2019f56](2019f56)) * create @skyux/code-examples NPM package (internal use only) ([#3091](#3091)) ([c0c9c48](c0c9c48)) * implement `[@docs](https://github.com/docs)Id` and `[@docs](https://github.com/docs)IncludeIds` JSDoc tags to capture documentation relationships in the manifest ([#3063](#3063)) ([ba33999](ba33999)) * **sdk/skyux-eslint:** add linting rule to detect the use of legacy icons ([#3061](#3061)) ([1abcf12](1abcf12)) ### Bug Fixes * **components/action-bars:** summary action bar should stack with back to top ([#3096](#3096)) ([#3107](#3107)) ([cc9b793](cc9b793)) * **components/ag-grid:** allow overriding grid min-height ([#3077](#3077)) ([#3088](#3088)) ([20670ca](20670ca)) * **components/ag-grid:** datepicker cell editor should handle refresh refocus ([#3056](#3056)) ([#3057](#3057)) ([fa878fe](fa878fe)) * **components/ag-grid:** refocus cell editors on api refresh ([#3087](#3087)) ([#3092](#3092)) ([c387ac2](c387ac2)) * **components/ag-grid:** row delete confirmation event handling ([#3078](#3078)) ([#3089](#3089)) ([b9372f1](b9372f1)) * **components/datetime:** add missing harness exports ([#3079](#3079)) ([#3080](#3080)) ([6d30585](6d30585)) * **components/forms:** ensure form error always has `errorName` attribute for test harnesses ([#3071](#3071)) ([#3072](#3072)) ([da19379](da19379)) * **components/lists:** mark repeater item `reorderable` property as internal as a consumer setting this property has no affect ([#3106](#3106)) ([#3108](#3108)) ([ec89181](ec89181)) * **components/text-editor:** allow initializing as disabled ([#3099](#3099)) ([#3102](#3102)) ([b4b55db](b4b55db)) * **components/text-editor:** value initializing for multiple text-editors ([#3067](#3067)) ([#3070](#3070)) ([b0b3533](b0b3533)) * **components/toast:** toasts read to assistive technology on initial rendering ([#3104](#3104)) ([#3105](#3105)) ([a115bd8](a115bd8)) ### Deprecations * deprecated action button icon `iconType` input and checkbox and radio button `icon` inputs in favor of new `iconName` input which utilizes SVG icons ([#3062](#3062)) ([567f922](567f922)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: John White <750350+johnhwhite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 Cherry picked from #3071 fix(components/forms): ensure form error always has
errorNameattribute for test harnessesAB#3199778