Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single endpoint that visualizes new table. #7

Closed
wants to merge 1 commit into from

Conversation

bkyryliuk
Copy link
Owner

… (#6)

  • Create additional endpoint that vizualized the new table

  • Unit tests

  • Use proper schema depending on the engine

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@bkyryliuk bkyryliuk force-pushed the bogdan/viz_integration branch 3 times, most recently from 6523436 to 39af578 Compare April 16, 2020 17:33
@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #7 into master will increase coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   65.49%   65.51%   +0.02%     
==========================================
  Files         571      571              
  Lines       29889    29910      +21     
  Branches     3040     3040              
==========================================
+ Hits        19577    19597      +20     
- Misses      10128    10129       +1     
  Partials      184      184              
Flag Coverage Δ
#javascript 58.77% <ø> (ø)
#mysql 70.18% <95.00%> (+0.03%) ⬆️
#postgres 70.15% <95.00%> (+0.02%) ⬆️
#python 70.27% <95.00%> (+0.02%) ⬆️
#sqlite 70.02% <95.00%> (+0.03%) ⬆️
#unittest 65.51% <95.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
superset/views/core.py 75.40% <94.59%> (+0.23%) ⬆️
superset/security/manager.py 89.11% <100.00%> (ø)
superset/views/base.py 72.81% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b11b44...39af578. Read the comment docs.

…#6)

* Create additional endpoint that vizualized the new table

* Unit tests

* Use proper schema depending on the engine
@bkyryliuk bkyryliuk force-pushed the bogdan/viz_integration branch from 39af578 to 7e84cd4 Compare April 16, 2020 20:18
@bkyryliuk bkyryliuk closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants