Fix: center on node feature works with collapsible disabled #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7acc5ec.
|
Apologies, realised I accidentally created this PR from master on my fork. Closing this out in favour of #457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386.
If you disable
collapsible, the "center on node" feature (via dimensions prop) ceases to work. My understanding is this due to the fact that a click on the node wouldn't trigger an update of the component. This PR adds thewasClickedstate to theshouldNotTransformcriteria. Tested this locally and it seems to work, as shown in attached clip.screenrecording.mov