Add scale-to-fit view mode

[bk138]

TODOs

• add button
• add menu entry
• wire up
• harmonise fullscreen button: make toggle as well
• get correct factor for scaled view
• impl scaling logic
• impl centering logic
• scale input as well
• 2nd viewerwindow does not setup mode correctly
• set mode should be remembered globally across restarts

Resources

• https://docs.wxwidgets.org/3.2/classwx_d_c.html

[muava12]

Yes we need this feature. for now is there a way to make it fit on window?

[bk138]

WIP, see the PR 🙂

[bk138]

example: https://docs.wxwidgets.org/3.2/classwx_d_c.html#aee6d97d655f20039745b5f6fb43a2d51

[geekley]

There is so much wasted spaced too... for starters, you could unify the tab bar, toolbar, status bar and menus in a single row. You could even have drop-downs for the server and bookmarks too, so everything is in a single row.

Also, what is the point of fullscreen if most elements will still occupy space?
It doesn't remove toolbar, status bar, statistics and the tabs bar.
The only thing that should be in the fullscreen is the other device's screen, and a way to exit fullscreen, which could be:

• a key combo (e.g. Ctrl+F11) that's never grabbed by the device, showed when you enter fullscreen (like Firefox does)
• a button to exit fullscreen that appears when you hover the top edge of the screen (like Firefox); or that is always visible on top of the content (without taking space away from it)

This way you could maximize usable screen space, which would be great along with this feature request.

[bk138]

@geekley please open a separate issue about this or better yet, a full PR :-)