Fix get parent field #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,13 +31,16 @@ end | |||
| function rules.fieldsDefinedOnType(node, context) | |||
| if context.objects[#context.objects] == false then | |||
| local parent = context.objects[#context.objects - 1] | |||
| if(parent.__type == 'List') then | |||
| parent = parent.ofType | |||
| end | |||
| error('Field "' .. node.name.value .. '" is not defined on type "' .. parent.name .. '"') | |||
There was a problem hiding this comment.
I think Field "field" is not defined on type "[Parent]" here would be better (brackets to indicate List type).
There was a problem hiding this comment.
I see where you are going but i think the message is correct now since "field" is part of the "parent" definition and has nothing to do with the list. For example:
"is_complete" is a property of "task" type sounds good but
"is_complete" is a property of "[task]" type is a bit wired
|
Thanks again! Let me know if you have any questions about my feedback. |
ruslantalpa
force-pushed
the
fix_get_parent_field
branch
from
761f37e to
7ba7b5f
Compare
|
Your suggestions implemented. Waiting for this to be merged in order to continue with introspection and fixing some "missing checks/defaultTypeResolve" in relation to unions and interfaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs and adds missing handling of Union type