Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7918] Design Feedback and other cleanup #136

Merged
merged 3 commits into from
May 10, 2024
Merged

[PM-7918] Design Feedback and other cleanup #136

merged 3 commits into from
May 10, 2024

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented May 3, 2024

๐ŸŽŸ๏ธ Tracking

PM-7918

๐Ÿ“” Objective

Implement feedback from @danielleflinn , as well as some additional cleanup I spotted along the way

๐Ÿ“ธ Screenshots

Before After
before-home after-home
before-page after-page

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jprusik jprusik requested a review from a team as a code owner May 3, 2024 20:00
@jprusik jprusik self-assigned this May 3, 2024
Comment on lines +55 to +56
// https://github.com/facebook/docusaurus/issues/9665
// https://github.com/facebook/docusaurus/issues/9688
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion on both facebook/docusaurus#9665 and facebook/docusaurus#9688 offers some workarounds, but they didn't work well here without a lot of extra refactors which I opted not to get into here.

Comment on lines -62 to -72
.theme-doc-markdown > header:first-of-type details > summary {
list-style: none;
}
.theme-doc-markdown > header:first-of-type details > summary::after {
font-size: 24px;
content: " โ–ธ";
}
.theme-doc-markdown > header:first-of-type details[open] > summary::after {
font-size: 24px;
content: " โ–พ";
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover styling from 26a4ff2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed thanks to facebook/docusaurus#10061 in v3.3.0

@jprusik jprusik enabled auto-merge (squash) May 6, 2024 15:11
@jprusik jprusik merged commit 7ff5c80 into main May 10, 2024
3 checks passed
@jprusik jprusik deleted the pm-7918 branch May 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants