Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17804] Add failing repository tests #5405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Feb 14, 2025

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

For @BTreston to review.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@eliykat eliykat changed the title Add failing repository tests [PM-17804] Add failing repository tests Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 44.56%. Comparing base (54d59b3) to head (70fc9bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5405   +/-   ##
=======================================
  Coverage   44.56%   44.56%           
=======================================
  Files        1501     1501           
  Lines       69811    69811           
  Branches     6283     6283           
=======================================
  Hits        31109    31109           
  Misses      37371    37371           
  Partials     1331     1331           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 6f61e292-d88b-4b4b-b697-137694f8120d

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant