Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17593] Remove Multi-Org Enterprise feature flag #5351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17593

📔 Objective

Remove the feature flag for multi-organization enterprises.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 30, 2025 17:10
@jonashendrickx jonashendrickx requested a review from r-tome January 30, 2025 17:10
Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Provider portal for multi-organization enterprises pm-12275-multi-organization-enterprises ✅ all references removed

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.22%. Comparing base (443a147) to head (6441d3e).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/AdminConsole/Views/Providers/Edit.cshtml 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5351      +/-   ##
==========================================
- Coverage   44.31%   44.22%   -0.09%     
==========================================
  Files        1483     1487       +4     
  Lines       68440    68580     +140     
  Branches     6174     6176       +2     
==========================================
+ Hits        30326    30332       +6     
- Misses      36805    36939     +134     
  Partials     1309     1309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb61fd806-74e1-4403-853b-1cb1d213f34c

Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Heap_Inspection /src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs: 19
LOW Heap_Inspection /src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs: 29
LOW Heap_Inspection /src/Core/Settings/GlobalSettings.cs: 268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants