-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2708] Upgrading from a password manager only subscription #4536
Merged
cyprain-okeke
merged 2 commits into
main
from
ac-2708-upgrade-password-manager-subscription
Jul 26, 2024
Merged
[AC-2708] Upgrading from a password manager only subscription #4536
cyprain-okeke
merged 2 commits into
main
from
ac-2708-upgrade-password-manager-subscription
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
LaunchDarkly flag references🔍 1 flag added or modified
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4536 +/- ##
==========================================
+ Coverage 41.57% 41.58% +0.01%
==========================================
Files 1268 1268
Lines 60087 60100 +13
Branches 5508 5512 +4
==========================================
+ Hits 24980 24994 +14
+ Misses 33948 33945 -3
- Partials 1159 1161 +2 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
cturnbull-bitwarden
previously approved these changes
Jul 26, 2024
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
cturnbull-bitwarden
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2708
📔 Objective
The change is to change the subscription for when a customer is upgrade from a Password Manager-only subscription.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes