Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2648] Remove Organization.FlexibleCollections from Models #4529

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2648

📔 Objective

Remove all references to Organization.FlexibleCollections from all Request/Reponse/Data models. This does not remove it from the Entity layer as it still exists in the database at this time.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.59%. Comparing base (88d5a97) to head (241bb1a).
Report is 4 commits behind head on main.

Files Patch % Lines
...odels/Response/ProfileOrganizationResponseModel.cs 22.72% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4529      +/-   ##
==========================================
+ Coverage   41.57%   41.59%   +0.02%     
==========================================
  Files        1268     1268              
  Lines       60091    60085       -6     
  Branches     5509     5510       +1     
==========================================
+ Hits        24981    24992      +11     
+ Misses      33950    33932      -18     
- Partials     1160     1161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details091f496f-7813-4d31-926f-89eebcb52366

No New Or Fixed Issues Found

@vincentsalucci vincentsalucci merged commit 903c412 into main Jul 23, 2024
51 of 52 checks passed
@vincentsalucci vincentsalucci deleted the ac/ac-2648/remove-org-fc-refs-from-models branch July 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants