Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idphost to organization entity #4523

Closed
wants to merge 15 commits into from
Closed

add idphost to organization entity #4523

wants to merge 15 commits into from

Conversation

kspearrin
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 41.58%. Comparing base (88d5a97) to head (1daa970).
Report is 4 commits behind head on main.

Files Patch % Lines
...dminConsole/Controllers/OrganizationsController.cs 0.00% 12 Missing ⚠️
...esponse/Organizations/OrganizationResponseModel.cs 0.00% 2 Missing ⚠️
...Auth/Models/Request/OrganizationIdpRequestModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
+ Coverage   41.57%   41.58%   +0.01%     
==========================================
  Files        1268     1269       +1     
  Lines       60091    60117      +26     
  Branches     5509     5513       +4     
==========================================
+ Hits        24981    24999      +18     
- Misses      33950    33957       +7     
- Partials     1160     1161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Logo
Checkmarx One – Scan Summary & Details18b5b31f-eb0f-40f0-94eb-17d0ea6d9dbd

No New Or Fixed Issues Found

@kspearrin kspearrin closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant