Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4311] Populate collection external id on import #4510

Merged

Conversation

aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-4311

📔 Objective

CreateCiphers is not adding the externalid column to build the table. This is adding it in order to properly import the ExternalId

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-rosado aj-rosado requested a review from a team as a code owner July 15, 2024 10:27
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc7dfa0d8-cb54-4493-8f37-efc961a276c3

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.49%. Comparing base (02b3453) to head (566758c).
Report is 1 commits behind head on main.

Files Patch % Lines
...ture.Dapper/Vault/Repositories/CipherRepository.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4510      +/-   ##
==========================================
- Coverage   41.49%   41.49%   -0.01%     
==========================================
  Files        1268     1268              
  Lines       59985    59988       +3     
  Branches     5486     5486              
==========================================
  Hits        24893    24893              
- Misses      33937    33940       +3     
  Partials     1155     1155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ttalty ttalty merged commit ad55493 into main Jul 24, 2024
51 of 52 checks passed
@ttalty ttalty deleted the tools/PM-4311/populate-collection-externalid-when-importing branch July 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants