-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include device application channel #4462
base: shard-notification-hub
Are you sure you want to change the base?
Conversation
Enables beta application push notifications
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shard-notification-hub #4462 +/- ##
==========================================================
- Coverage 41.42% 41.13% -0.29%
==========================================================
Files 1268 1263 -5
Lines 60400 60198 -202
Branches 5520 5496 -24
==========================================================
- Hits 25020 24763 -257
- Misses 34231 34296 +65
+ Partials 1149 1139 -10 ☔ View full report in Codecov by Sentry. |
@@ -9,7 +9,8 @@ | |||
@RevisionDate DATETIME2(7), | |||
@EncryptedUserKey VARCHAR(MAX) = NULL, | |||
@EncryptedPublicKey VARCHAR(MAX) = NULL, | |||
@EncryptedPrivateKey VARCHAR(MAX) = NULL | |||
@EncryptedPrivateKey VARCHAR(MAX) = NULL, | |||
@ApplicationChannel TINYINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ Defaults on procs are needed when parameters are added.
Enables beta application push notifications
🎟️ Tracking
📔 Objective
Adds application channel to device registration, which enables beta publications with push notifications enabled.
WIP:
Depends on #4450
Still need to create EF migrations, but there were some additional migration changes that should be resolved by #4448
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes