Include device application channel #4462
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables beta application push notifications
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shard-notification-hub #4462 +/- ##
==========================================================
- Coverage 41.42% 41.13% -0.29%
==========================================================
Files 1268 1263 -5
Lines 60400 60198 -202
Branches 5520 5496 -24
==========================================================
- Hits 25020 24763 -257
- Misses 34231 34296 +65
+ Partials 1149 1139 -10 ☔ View full report in Codecov by Sentry. |
withinfocus
reviewed
Jul 12, 2024
| @@ -9,7 +9,8 @@ | |||
| @RevisionDate DATETIME2(7), | |||
| @EncryptedUserKey VARCHAR(MAX) = NULL, | |||
| @EncryptedPublicKey VARCHAR(MAX) = NULL, | |||
| @EncryptedPrivateKey VARCHAR(MAX) = NULL | |||
| @EncryptedPrivateKey VARCHAR(MAX) = NULL, | |||
| @ApplicationChannel TINYINT | |||
There was a problem hiding this comment.
⛏️ Defaults on procs are needed when parameters are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables beta application push notifications
🎟️ Tracking
📔 Objective
Adds application channel to device registration, which enables beta publications with push notifications enabled.
WIP:
Depends on #4450
Still need to create EF migrations, but there were some additional migration changes that should be resolved by #4448
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes